Re: [PATCH can-next v4 7/9] selftests: can: add J1939 TP/ETP multi-frame tests against CAN_RAW
From: Marc Kleine-Budde
Date: Fri Nov 20 2026 - 05:30:30 EST
On 19.11.2026 23:54:38, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] The commit message argues that test_j1939_multi.sh can stay in
> the default TEST_PROGS run (not TEST_PROGS_EXTENDED or XFAIL) because…
> - [Low] In j1939_helpers.h, errqueue_empty_ok() is documented as "Is the
> error queue of s still empty after J1939_NEG_RECV_TIMEOUT_MS?".
pw-bot: cr
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature