[PATCH v2 2/3] iio: adc: rohm-bd79112: Add chip info structure

From: Matti Vaittinen

Date: Fri Nov 20 2026 - 07:28:21 EST


From: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

A new ADC variant, ROHM BD79111 is going to be supported by this same
driver. As a preparatory step, introduce chip-specific data and pick it
at probe time based on the spi-match data. This allows describing the
necessary hardware differencies in data structures, which tends to
result cleaner solution than some CHIP_ID specific switch-case blocks.

Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

---
Revision history:
v1 => v2:
- Split the chip-ID introduction into own patch as suggested by Andy.
---
drivers/iio/adc/rohm-bd79112.c | 45 +++++++++++++++++++++++++++-------
1 file changed, 36 insertions(+), 9 deletions(-)

diff --git a/drivers/iio/adc/rohm-bd79112.c b/drivers/iio/adc/rohm-bd79112.c
index 2506fec7be84..04084e88984a 100644
--- a/drivers/iio/adc/rohm-bd79112.c
+++ b/drivers/iio/adc/rohm-bd79112.c
@@ -26,7 +26,15 @@

#define BD79112_MAX_NUM_CHANNELS 32

+struct bd79112_data;
+
+struct bd7911x_chip_data {
+ const char * const *chan_names;
+ int (*init_disable_gpios)(struct bd79112_data *data);
+};
+
struct bd79112_data {
+ const struct bd7911x_chip_data *cd;
struct spi_device *spi;
struct regmap *map;
struct device *dev;
@@ -398,6 +406,19 @@ static unsigned int bd79112_get_gpio_pins(const struct iio_chan_spec *cs, int nu
return gpio_channels;
}

+static int bd79112_disable_gpios(struct bd79112_data *data)
+{
+ int ret;
+
+ for (unsigned int i = 0; i < BD79112_NUM_GPIO_EN_REGS; i++) {
+ ret = regmap_write(data->map, BD79112_FIRST_GPIO_EN_REG + i, 0);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
/* ADC channels as named in the data-sheet */
static const char * const bd79112_chan_names[] = {
"AGIO0A", "AGIO1A", "AGIO2A", "AGIO3A", /* 0 - 3 */
@@ -410,6 +431,11 @@ static const char * const bd79112_chan_names[] = {
"AGIO12B", "AGIO13B", "AGIO14B", "AGIO15B", /* 28 - 31 */
};

+static const struct bd7911x_chip_data bd79112_chip_data = {
+ .chan_names = bd79112_chan_names,
+ .init_disable_gpios = bd79112_disable_gpios,
+};
+
static int bd79112_probe(struct spi_device *spi)
{
struct bd79112_data *data;
@@ -425,6 +451,10 @@ static int bd79112_probe(struct spi_device *spi)
return -ENOMEM;

data = iio_priv(iio_dev);
+ data->cd = spi_get_device_match_data(spi);
+ if (!data->cd)
+ return -ENODEV;
+
data->spi = spi;
data->dev = dev;
data->map = devm_regmap_init(dev, NULL, data, &bd79112_regmap);
@@ -476,7 +506,7 @@ static int bd79112_probe(struct spi_device *spi)
iio_dev->channels = cs;

for (i = 0; i < iio_dev->num_channels; i++)
- cs[i].datasheet_name = bd79112_chan_names[cs[i].channel];
+ cs[i].datasheet_name = data->cd->chan_names[cs[i].channel];

iio_dev->info = &bd79112_info;
iio_dev->name = "bd79112";
@@ -488,12 +518,9 @@ static int bd79112_probe(struct spi_device *spi)
* without having to worry about some pins being initially used for
* GPIO.
*/
- for (i = 0; i < BD79112_NUM_GPIO_EN_REGS; i++) {
- ret = regmap_write(data->map, BD79112_FIRST_GPIO_EN_REG + i, 0);
- if (ret)
- return dev_err_probe(dev, ret,
- "Failed to initialize channels\n");
- }
+ ret = data->cd->init_disable_gpios(data);
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to initialize channels\n");

ret = devm_iio_device_register(data->dev, iio_dev);
if (ret)
@@ -523,13 +550,13 @@ static int bd79112_probe(struct spi_device *spi)
}

static const struct of_device_id bd79112_of_match[] = {
- { .compatible = "rohm,bd79112" },
+ { .compatible = "rohm,bd79112", .data = &bd79112_chip_data },
{ }
};
MODULE_DEVICE_TABLE(of, bd79112_of_match);

static const struct spi_device_id bd79112_id[] = {
- { .name = "bd79112" },
+ { .name = "bd79112", .driver_data = (kernel_ulong_t)&bd79112_chip_data },
{ }
};
MODULE_DEVICE_TABLE(spi, bd79112_id);
--
2.56.1

Attachment: signature.asc
Description: PGP signature