Re: [PATCH v2 2/3] iio: adc: rohm-bd79112: Add chip info structure
From: Andy Shevchenko
Date: Fri Nov 20 2026 - 09:37:01 EST
On Fri, Nov 20, 2026 at 02:28:00PM +0200, Matti Vaittinen wrote:
>
> A new ADC variant, ROHM BD79111 is going to be supported by this same
> driver. As a preparatory step, introduce chip-specific data and pick it
> at probe time based on the spi-match data. This allows describing the
> necessary hardware differencies in data structures, which tends to
> result cleaner solution than some CHIP_ID specific switch-case blocks.
...
> + data->cd = spi_get_device_match_data(spi);
> + if (!data->cd)
> + return -ENODEV;
ENODATA
...
Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
--
With Best Regards,
Andy Shevchenko