Re: [PATCH] HID: corsair: cancel LED work again after unregistering the LED

From: Andreas Claesson

Date: Fri Nov 20 2026 - 07:32:44 EST


On Thu, 19 Nov 2026, Jiri Kosina wrote:
> Applied to hid.git#for-7.4/upstream-fixes, thanks.

Thanks, but I think this one should be dropped again, sorry for the
noise.

for-7.4/upstream-fixes also has cc8d022e8679 ("HID: corsair: use
disable_work_sync() to tear down the LED workers") from Danish, which
fixes the same bug and which I had missed when I sent mine. With the
work disabled before led_classdev_unregister(), the LED-off request can
no longer queue it, so the cancel_work_sync() calls my patch adds on
top (e624a56578e5) do nothing, and the comment it adds is no longer
true.

It is harmless, so if dropping it is inconvenient I can send a revert
instead, whichever you prefer.

Thanks,
Andreas