Re: [PATCH V1] accel/amdxdna: Reject a zero sized buffer in amdxdna_gem_prime_import()
From: Christian König
Date: Fri Nov 20 2026 - 07:32:49 EST
On 11/20/26 03:35, Lizhi Hou wrote:
> Zero sized buffer is not supported. Check the buffer size and return
> -EINVAL if the size is zero.
Oh that is surprising a zero sized buffer shouldn't be supported by DMA-buf in the first place.
Doesn't DMA-buf check that somewhere?
Regards,
Christian.
>
> Fixes: e486147c912f ("accel/amdxdna: Add BO import and export")
> Signed-off-by: Lizhi Hou <lizhi.hou@xxxxxxx>
> ---
> drivers/accel/amdxdna/amdxdna_gem.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/accel/amdxdna/amdxdna_gem.c b/drivers/accel/amdxdna/amdxdna_gem.c
> index ffe12a722dfe..4d7f3de88cd3 100644
> --- a/drivers/accel/amdxdna/amdxdna_gem.c
> +++ b/drivers/accel/amdxdna/amdxdna_gem.c
> @@ -1133,6 +1133,9 @@ amdxdna_gem_prime_import(struct drm_device *dev, struct dma_buf *dma_buf)
> struct sg_table *sgt;
> int ret;
>
> + if (!dma_buf->size)
> + return ERR_PTR(-EINVAL);
> +
> get_dma_buf(dma_buf);
>
> attach = dma_buf_attach(dma_buf, dev->dev);