Re: [PATCH] iio: buffer: kfifo: reject lengths exceeding the kmalloc limit

From: Andy Shevchenko

Date: Fri Nov 20 2026 - 11:23:25 EST


On Fri, Nov 20, 2026 at 09:21:29PM +0800, YuanZhe Liu wrote:
> __iio_allocate_kfifo() rejects lengths that would overflow an unsigned
> int after kfifo rounds them up to the next power of two, but the byte
> size handed to __kfifo_alloc() can still be beyond what kmalloc() can
> serve.
>
> The kfifo buffer is allocated with kmalloc(), which is limited to
> KMALLOC_MAX_SIZE. A larger request has an allocation order above
> MAX_PAGE_ORDER, so the page allocator's order sanity check fires and
> enabling the buffer ends with a WARNING instead of a clean error.
>
> The buffer length is set through buffer/length, which accepts any value
> up to UINT_MAX. With the voltage and timestamp scan channels enabled,
> a length of 262349 makes the rounded up size exceed KMALLOC_MAX_SIZE
> and triggers the warning on buffer/enable.
>
> Also reject lengths whose rounded up size does not fit into
> KMALLOC_MAX_SIZE, so that enabling the buffer fails with -EINVAL.

...

> if (roundup_pow_of_two(length) > UINT_MAX / bytes_per_datum)
> return -EINVAL;

So many developers of this patch and there is no clarification
why we need to keep this check.

> + /*
> + * The kfifo memory is allocated with kmalloc(), so the size must also
> + * fit into the largest allocation kmalloc() can serve. Larger
> + * requests need an order above MAX_PAGE_ORDER and are refused by the
> + * page allocator with a warning.
> + */
> + if (roundup_pow_of_two(length) > KMALLOC_MAX_SIZE / bytes_per_datum)
> + return -EINVAL;

--
With Best Regards,
Andy Shevchenko