[PATCH v2] iio: buffer: kfifo: reject lengths exceeding the kmalloc limit
From: YuanZhe Liu
Date: Fri Nov 20 2026 - 11:44:33 EST
__iio_allocate_kfifo() only rejects lengths that would overflow an
unsigned int after kfifo rounds them up to the next power of two, but
the byte size handed to __kfifo_alloc() can still be beyond what
kmalloc() can serve.
The kfifo buffer is allocated with kmalloc(), which is limited to
KMALLOC_MAX_SIZE. A larger request has an allocation order above
MAX_PAGE_ORDER, so the page allocator's order sanity check fires and
enabling the buffer ends with a WARNING instead of a clean error.
The buffer length is set through buffer/length, which accepts any value
up to UINT_MAX. With the voltage and timestamp scan channels enabled,
a length of 262349 makes the rounded up size exceed KMALLOC_MAX_SIZE
and triggers the warning on buffer/enable.
Reject lengths whose rounded up size does not fit into KMALLOC_MAX_SIZE
so that enabling the buffer fails with -EINVAL. This bound is stricter
than the unsigned int overflow check it replaces, because
KMALLOC_MAX_SIZE is far below UINT_MAX, so that check is removed.
Co-developed-by: Bin Yu <byu@xxxxxxxxxxxxx>
Signed-off-by: Bin Yu <byu@xxxxxxxxxxxxx>
Co-developed-by: Cheng Wen <wencheng@xxxxxxxxxxxxx>
Signed-off-by: Cheng Wen <wencheng@xxxxxxxxxxxxx>
Signed-off-by: YuanZhe Liu <25031212351@xxxxxxxxxxxxxxxxx>
---
v2:
- Drop the unsigned int overflow check. It is subsumed by the new
KMALLOC_MAX_SIZE bound: a length that would overflow the kfifo
element counter exceeds KMALLOC_MAX_SIZE as well (Andy Shevchenko).
---
drivers/iio/buffer/kfifo_buf.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/buffer/kfifo_buf.c b/drivers/iio/buffer/kfifo_buf.c
index b67ea6468226..65906dfffc04 100644
--- a/drivers/iio/buffer/kfifo_buf.c
+++ b/drivers/iio/buffer/kfifo_buf.c
@@ -29,10 +29,14 @@ static inline int __iio_allocate_kfifo(struct iio_kfifo *buf,
return -EINVAL;
/*
- * Make sure we don't overflow an unsigned int after kfifo rounds up to
- * the next power of 2.
+ * The kfifo memory is allocated with kmalloc(), which cannot serve
+ * more than KMALLOC_MAX_SIZE. A larger request needs an allocation
+ * order above MAX_PAGE_ORDER and is refused by the page allocator
+ * with a warning. KMALLOC_MAX_SIZE is far below UINT_MAX, so this
+ * also keeps the element count rounded up by kfifo within an
+ * unsigned int.
*/
- if (roundup_pow_of_two(length) > UINT_MAX / bytes_per_datum)
+ if (roundup_pow_of_two(length) > KMALLOC_MAX_SIZE / bytes_per_datum)
return -EINVAL;
return __kfifo_alloc((struct __kfifo *)&buf->kf, length,
--
2.34.1