Re: [PATCH] hwmon: (coretemp) Remove unused for_each_sibling() and name_attr

From: Guenter Roeck

Date: Fri Nov 20 2026 - 14:26:21 EST


On Fri, Nov 20, 2026 at 07:59:26PM +0300, Asaf Nuri Bertizlioğlu wrote:
> The for_each_sibling() macro lost its only user in commit
> e1b370b64031 ("hwmon: (coretemp) Simplify sibling management").
>
> The name_attr member of struct platform_data has been unused since
> commit d72d19c26c41 ("hwmon: (coretemp) Convert to use
> devm_hwmon_device_register_with_groups"), which left the "name"
> attribute to the hwmon core.
>
> Remove both. No functional change.
>
> Built with CONFIG_SMP=y and CONFIG_SMP=n at W=1 with no new
> warnings. Apart from the struct platform_data allocation size,
> which shrinks from 88 to 56 bytes, the generated code is unchanged.
>
> The unused definitions were found with an LLM-based coding assistant,
> which also drafted this changelog. Both findings were confirmed with
> gcc -Wunused-macros, git grep and the git history.
>
> Signed-off-by: Asaf Nuri Bertizlioğlu <asafbertizlioglu@xxxxxxxxx>

Applied.

Thanks,
Guenter