Re: [PATCH v3 1/2] hwmon: (pmbus/max16601) Support byte data writes on VSA rail
From: Guenter Roeck
Date: Fri Nov 20 2026 - 14:28:08 EST
On Fri, Nov 20, 2026 at 02:44:15AM +0000, Arthur Korn wrote:
> MAX16601 exposes the secondary VSA rail on virtual PMBus page 2 backed
> by a separate I2C client (data->vsa), while page 1 is a read-only
> virtual page for VCORE input current and power telemetry. Although the
> driver routes byte reads on page 2 to data->vsa via max16601_read_byte()
> and PMBUS_CLEAR_FAULTS byte writes via max16601_write_byte(), it does
> not implement write_byte_data(), and max16601_write_byte() falls through
> to -ENODATA on virtual page 1.
>
> As a result, PMBus 1.2+ byte-data status writes from pmbus_core (such as
> clearing individual status bits in pmbus_get_boolean() or clearing
> STATUS_CML faults during probe) on page 2 are sent to the primary VCORE
> client instead of data->vsa, and byte writes on virtual page 1 fall
> through to page 0.
>
> Implement max16601_write_byte_data() mirroring max16601_read_byte() to
> forward page 2 byte-data writes to data->vsa and reject virtual page 1
> with -EOPNOTSUPP, and reject virtual page 1 in max16601_write_byte() as
> well.
>
> Fixes: 2138f8853a00 ("hwmon: (pmbus) Driver for Maxim MAX16601")
> Signed-off-by: Arthur Korn <akorn@xxxxxxxxxx>
Applied.
Thanks,
Guenter