Re: [PATCH v2 3/3] iio: adc: rohm-bd79112: Support ROHM BD79111

From: Jonathan Cameron

Date: Fri Nov 20 2026 - 21:02:09 EST


On Fri, 20 Nov 2026 16:44:38 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Fri, Nov 20, 2026 at 02:28:28PM +0200, Matti Vaittinen wrote:
> >
> > ROHM BD79111 is very similar to the BD79112. Both are ADC/GPIO devices,
> > where pins can be configured to be either used as GPIO or ADC inputs.
> > ADCs are 12-bit SAR ADCs and GPIOs support input/output but not being IRQ
> > sources.
> >
> > The main difference is amount of channels/GPIOs. The BD79112 has 32 pins
> > for this use, the BD79111 has 16. Furthermore, the BD79111 data-sheet
> > promises 0.5 MSPS sample rate with maximum of 10 MHz SPI clock, whereas
> > the BD79112 data-sheet mentioned 1MSPS rate with maximum of 20 MHz SPI
> > clock.
>
> ...
>
> > - Return -ENODATA instead of -ENODEV when SPI match data is not
> > available.
>
> I guess you were distracted by something, the error code is now introduced in
> the very previous patch, fix it there.
>
> ...
>
> > - tristate "Rohm BD79112 ADC driver"
> > + tristate "ADC/GPIO Driver for ROHM BD79112 et al."
>
> > - * ROHM ADC driver for BD79112 signal monitoring hub.
> > + * ROHM ADC/GPIO driver for BD79112 and similar signal monitoring hubs.
>
> Can this text be modified to be closer to the other two?
> Something like:
>
> * ADC/GPIO Driver for ROHM BD79112 and similar signal monitoring hubs.

I had nothing to add and nearly picked it up with tweaks. Given
this is something you may well want to feedback on (or adopt as
is!) I decided to ask for a v3.

Given this is small and in a clean state, send it whenever you are
ready - no need to wait a week in this case.

Thanks,

Jonathan

>
> > -MODULE_DESCRIPTION("Driver for ROHM BD79112 ADC/GPIO");
> > +MODULE_DESCRIPTION("ADC/GPIO Driver for ROHM BD79112 et al.");
>
> ...
>
> Otherwise LGTM,
> Reviewed-by; Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
>