[PATCH net v2] netdevsim: fix rate node leak during reload and removal

From: xietangxin

Date: Sat Nov 21 2026 - 06:10:49 EST


netdevsim allows switching the eswitch mode to switchdev with zero VFs
and creating rate nodes on such a device. However during device teardown
nsim_dev_reload_destroy() only drops the eswitch back to legacy when VFs
were configured, so the rate nodes are never destroyed and trigger the
WARN_ON(devlink_rates_check()) in devlink_free():

WARNING: net/devlink/core.c:544 at devlink_free+0x18c/0x26c, CPU#2: bash/5032
Modules linked in: netdevsim ...
CPU: 2 UID: 0 PID: 5032 Comm: bash Not tainted 7.4.0-rc3+ #77 PREEMPTLAZY
Call trace:
devlink_free+0x18c/0x26c (P)
nsim_drv_remove+0x9c/0xb4 [netdevsim]
nsim_bus_remove+0x10/0x1c [netdevsim]
del_device_store+0x110/0x190 [netdevsim]
...

The rate nodes are also left behind on the devlink reload path, where
they trigger the WARN in devlink_reload_reinit_sanity_check() instead:

WARNING: net/devlink/dev.c:437 at devlink_reload_reinit_sanity_check+0x110/0x148, CPU#3: devlink/5205
Modules linked in: netdevsim ...
CPU: 3 UID: 0 PID: 5205 Comm: devlink Not tainted 7.4.0-rc3+ #77 PREEMPTLAZY
Call trace:
devlink_reload_reinit_sanity_check+0x110/0x148 (P)
devlink_reload+0x218/0x228
devlink_nl_reload_doit+0x3dc/0x5b4
...

Evaluate the eswitch mode check unconditionally, so rate nodes are
destroyed whether or not any VF was ever configured. Note this also
resets a zero-VF switchdev device back to legacy mode on reload, like
the existing VF case.

Reproduce by:
$ echo "10 1" > /sys/bus/netdevsim/new_device
$ devlink dev eswitch set netdevsim/netdevsim10 mode switchdev
$ devlink port function rate add netdevsim/netdevsim10/n1
$ echo 10 > /sys/bus/netdevsim/del_device

Replacing the last step with "devlink dev reload netdevsim/netdevsim10"
hits the devlink_reload_reinit_sanity_check() WARN instead.

Fixes: 885226f5680e ("netdevsim: Implement support for devlink rate nodes")
Cc: stable@xxxxxxxxxxxxxxx
Reported-by: syzbot+bbd81e1e2276c534dea1@xxxxxxxxxxxxxxxxxxxxxxxxx
Closes: https://lore.kernel.org/netdev/6af9824c.920b2b3a.148c65.0009.GAE@xxxxxxxxxx/
Reported-by: Xuanqiang Luo <xuanqiang.luo@xxxxxxxxx>
Link: https://lore.kernel.org/all/17cc4251-04ae-41a7-a872-fc5cf525b58f@xxxxxxxxx/
Signed-off-by: xietangxin <xietangxin@xxxxxxxxxxxxxx>
---
v2: add reload path description
---
drivers/net/netdevsim/dev.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
index c6b17b387327..b483c25dfecd 100644
--- a/drivers/net/netdevsim/dev.c
+++ b/drivers/net/netdevsim/dev.c
@@ -1700,11 +1700,10 @@ static void nsim_dev_reload_destroy(struct nsim_dev *nsim_dev)
return;
debugfs_remove(nsim_dev->take_snapshot);

- if (nsim_dev_get_vfs(nsim_dev)) {
+ if (nsim_dev_get_vfs(nsim_dev))
nsim_bus_dev_set_vfs(nsim_dev->nsim_bus_dev, 0);
- if (nsim_esw_mode_is_switchdev(nsim_dev))
- nsim_esw_legacy_enable(nsim_dev, NULL);
- }
+ if (nsim_esw_mode_is_switchdev(nsim_dev))
+ nsim_esw_legacy_enable(nsim_dev, NULL);

nsim_dev_port_del_all(nsim_dev);
nsim_dev_hwstats_exit(nsim_dev);
--
2.43.0