Re: [PATCH net-next v2] net: mdio: handle broken-turn-around for non-PHY MDIO devices
From: Andrew Lunn
Date: Sat Nov 21 2026 - 14:29:07 EST
On Sat, Nov 21, 2026 at 08:07:34PM +0100, Bastian Germann wrote:
> Hi Andrew,
>
> On 11/21/26 18:06, Andrew Lunn wrote:
> > > Parse the property in of_mdiobus_register_phy() and
> > > of_mdiobus_register_device() instead, so it is handled in one place for
> > > both PHYs and other MDIO devices, and drop it from
> > > fwnode_mdiobus_phy_device_register().
> > This seems odd. "handled in one place", yet you do it in two?
> >
> > Is there a reason not to do it in __of_mdiobus_parse_phys() ?
>
> Yes. My v2 draft was exactly that (which is the reason for the commit
> message oddity) but I noticed that children with empty reg that are handled
> in the auto-scan loop would then not get the bit mask set, which is an
> unnecessary behavior change for PHYs.
Ah, O.K. I never liked that scan code filling in missing devices. It
has a warning not to do that. So i don't know if it is actually used.
Also, i could not find any in kernel dt blobs using
broken-turn-around. So we are not going to break anything.
Andrew
---
pw-bot: cr