Re: [PATCH v2 1/2] dt-bindings: iio: magnetometer: infineon,tlv493d-a1b6: add TLE493D-W2B6
From: Jonathan Cameron
Date: Sat Nov 21 2026 - 14:30:14 EST
On Sat, 21 Nov 2026 11:25:10 +0530
Viral Patel <viral8854@xxxxxxxxx> wrote:
> Add the Infineon TLE493D-W2B6, a 3D Hall effect magnetic sensor with
> 12-bit resolution per axis and an integrated temperature sensor,
> accessed over I2C. It is a second-generation sibling of the
> TLV493D-A1B6 with a different register interface, so it gets its own
> compatible, but it has the same supply range and the same /INT output
> sharing the SCL pin, so it fits the existing binding.
>
> The A0 to A3 variants of the part only differ in their default I2C
> address, so a single compatible covers all of them.
>
> Signed-off-by: Viral Patel <viral8854@xxxxxxxxx>
Hi Viral
A few comments inline. Nothing to stop me merging this if nothing
else comes up though!
Jonathan
> ---
> .../bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml | 14 ++++++++++++--
> MAINTAINERS | 6 ++++++
> 2 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
> index dd23a9370a71..3f0058cbf538 100644
> --- a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
> @@ -4,17 +4,27 @@
> $id: http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d-a1b6.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Infineon Technologies TLV493D Low-Power 3D Magnetic Sensor
> +title: Infineon Technologies TLV493D and TLE493D 3D Magnetic Sensors
>
> maintainers:
> - Dixit Parmar <dixitparmar19@xxxxxxxxx>
> + - Viral Patel <viral8854@xxxxxxxxx>
> +
> +description: |
Don't need to retain line wraps so IIRC > rather than | is appropriate.
> + 3D Hall effect magnetic sensors with an I2C interface. The /INT output
> + shares a pin with SCL.
> +
> + The A0 to A3 variants of the TLE493D-W2B6 only differ in their default
> + I2C address (0x35, 0x22, 0x78 and 0x44).
For a binding I'm not sure we need this level of detail. Perhaps
just keep the first sentence. I don't mind either way on this one.
>
> properties:
> $nodename:
> pattern: '^magnetometer@[0-9a-f]+$'
>
> compatible:
> - const: infineon,tlv493d-a1b6
> + enum:
> + - infineon,tle493d-w2b6
> + - infineon,tlv493d-a1b6
>
> reg:
> maxItems: 1
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 02015eaec312..c3004f683e78 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13117,6 +13117,12 @@ S: Maintained
> F: Documentation/devicetree/bindings/sound/infineon,peb2466.yaml
> F: sound/soc/codecs/peb2466.c
>
> +INFINEON TLE493D-W2B6 DRIVER
> +M: Viral Patel <viral8854@xxxxxxxxx>
> +L: linux-iio@xxxxxxxxxxxxxxx
> +S: Maintained
> +F: Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
I guess this is fine for most scripts, but I wonder if anything will drip up over
a file being listed in two maintainers entries. I wouldn't necessarily worry
about adding the binding to here as you have that line in the actual file anyway
to point people to include you on changes etc.
> +
> INFINEON TLV493D Driver
> M: Dixit Parmar <dixitparmar19@xxxxxxxxx>
> L: linux-iio@xxxxxxxxxxxxxxx
>