Re: Non-atomic copy_xxx_user problems

Matthias Urlichs (smurf@work.smurf.noris.de)
1 Jun 1997 23:39:36 +0200

Messages sorted by: [ date ][ thread ][ subject ][ author ]
Next message: Chris Evans: "3c59x.c"
Previous message: Andrew E. Mileski: "Re: Ext-2fs volume support (patch)"
Maybe in reply to: Bill Hawes: "Non-atomic copy_xxx_user problems"

Bill Hawes <whawes@star.net> writes:
> +#define COPY_TO_MSG "Non-atomic copy_to_user in %s at line %d\n"
> + printk(&COPY_TO_MSG[0], __FILE__, __LINE__); \

You might want to allocate one copy of these COPY_*_MSG strings in one .c
file and declaring the string external in the header. That way gcc won't
allocate a fresh copy for each file you compile.

That change should cut around half the bloat you're seeing (I'm guessing
here).

-- Il est mort, Jean Luc...

-- 
Matthias Urlichs         \  noris network GmbH  /  Xlink-POP Nürnberg 
Schleiermacherstraße 12   \   Linux+Internet   /   EMail: urlichs@noris.de
90491 Nürnberg (Germany)   \    Consulting+Programming+Networking+etc'ing
   PGP: 1024/4F578875   1B 89 E2 1C 43 EA 80 44  15 D2 29 CF C6 C7 E0 DE
       Click <A HREF="http://info.noris.de/~smurf/finger">here</A>.    42

Next message: Chris Evans: "3c59x.c"
Previous message: Andrew E. Mileski: "Re: Ext-2fs volume support (patch)"
Maybe in reply to: Bill Hawes: "Non-atomic copy_xxx_user problems"