i did
>
> > > > - struct ei_device *ei_local = (struct ei_device *) dev->priv;
> > > >
> > > > /* This can't happen unless somebody forgot to call ethdev_init(). */
> > > This variable IS used.
> > Where ?
>
> Non x86
>
> >
> > > > -int apm_get_info(char *buf, char **start, off_t fpos, int length, int dummy)
> > > > +int apm_get_info(char *buf)
> > >
> > > These are parameters passed by the calling function
> >
> > but there are not used !
>
> Please read a book on the C language. It doesn't matter if they are used or
> not you can't go around deleting them. This is beginner level programming.
It's why i say i make the diff before altering function callings as i
did for other stuff...
if you really want it, i can resend the whole patch with fixed functions
points (but not before monday as i leave my university for the week-end)
Flaming people before reading the whole message isn't very productive,
particularly for a forgoten diff that can easily be fixed.
anyway, i won't argue more with you as you've a better experience than
me in kernel programming.
> > > These are values used on other platforms
> >
> > maybe we can turn this in a macro that developp in
> > __real_flush_tlb_range on ia32 and other archs where it'sn't used ?
>
> What for - gcc isnt stupid.
sometimes it is. depending of version and optimizing level, gcc generate
lot of stupid opcodes (ia32 is particularly bugged) that slowly
disapear. i've seen multiple load of a value in registers, mulitple
reload of a non volatile register, pop and posh/moveq)of the same
register without any opcode between, inlining functions both kept as
function
and inlined, jumps bypassing nops, ...
<End of bersek mode>
One friend of mine has encountered the floppy bug when the eide driver
claim to use ressources used by the fdc. so it's not an alpha bug as
someone fixed it.
The guy say me that this bug is a few weeks old.
Have you a clue about it ?
Thanks.
PS: i cannot mail you directely:
----- Transcript of session follows -----
... while talking to lightning.swansea.uk.linux.org.:
>>> RCPT To:<alan@lxorguk.ukuu.org.uk>
<<< 550 rejected: administrative prohibition
550 <alan@lxorguk.ukuu.org.uk>... User unknown
Sorry for not answer you directely but we've some mta problems with
some servers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/