Re: PATCHES (unused code/vars...) for 2.3.18ac8

rmk@arm.linux.org.uk
Fri, 24 Sep 1999 14:52:23 +0100 (BST)

Thierry vignaud writes:
> Here are 2 patches :
> * unreachable_code.diff remove some code that cannot be executed
> (because of a previous return or break) and remove duplicated break
> * unused.diff remove some unused variables and parameters
> * flush_tlb_range.diff do the same for flush_tlb_range. Note that we
> should do used these unused paramaters else the "range" in the name is
> useless...
>
> I just see that i forgot to fix call to apm_get_info. don't forget it
> before applying the patch.
> <patches>

Some questions:

1. Do you have a book on basic C programming?
2. Can you go and read it?
3. Can you read the kernel source before making changes to assess
their impact properly?
4. Can you test your patches before mailing them onto l-k?

If the answer to 1 and 2 is yes, do so - you might learn something. Then
come back to l-k with a better, less brain-dead patch.
_____
|_____| ------------------------------------------------- ---+---+-
| | Russell King rmk@arm.linux.org.uk --- ---
| | | | http://www.arm.linux.org.uk/~rmk/aboutme.html / / |
| +-+-+ --- -+-
/ | THE developer of ARM Linux |+| /|\
/ | | | --- |
+-+-+ ------------------------------------------------- /\\\ |

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/