Re: [PATCH] address_space_operations unification

From: Linus Torvalds (torvalds@transmeta.com)
Date: Sat May 06 2000 - 14:53:36 EST


On Sat, 6 May 2000, Roman V. Shaposhnick wrote:

> I've attached a patch which appears to make address_space_operations' interface
> more logical and easy to use ( as it was discussed at linux-fsdevel ). The main
> idea was to change additional argument of all methods to something that
> interface do not care of, but all callers do. That's it.

I hate "cookies". Despicable. Why pass them in at all if they are not
supposed to be used for anything but callbacks?

What you did just added lots of ugly casts and private fields, because the
low-level FS's actually _did_ need to get "struct inode" or "struct
dentry".

In short, if this was disscussed on fs-devel, then I can only say that
"fs-devel" doesn't seem to have any taste at all. Worthless mailing list.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun May 07 2000 - 21:00:20 EST