[PATCH] Fix endianess in modpost when cross-compiling for sparc on i386

From: Mathieu Chouquet-Stringer
Date: Wed May 12 2004 - 14:31:28 EST


this simple patch makes the following code work again:

if (info->hdr->e_machine == EM_SPARC ||
info->hdr->e_machine == EM_SPARCV9) {
/* Ignore register directives. */
if (ELF_ST_TYPE(sym->st_info) == STT_REGISTER)

This portion of code is sparc specific and nothing else in modpost.c uses
e_machine meaning cross-compiling for sparc on i386 (or any little endian
machine) is the only way to experience the bug.

Without it, e_machine has the wrong value and modpost then generates a lot
of "*** Warning: \"symbol\" [filename.ko] undefined" messages.

--- scripts/modpost.c.orig 2004-05-12 13:58:58.000000000 -0400
+++ scripts/modpost.c 2004-05-12 14:05:20.000000000 -0400
@@ -267,6 +267,7 @@
hdr->e_shoff = TO_NATIVE(hdr->e_shoff);
hdr->e_shstrndx = TO_NATIVE(hdr->e_shstrndx);
hdr->e_shnum = TO_NATIVE(hdr->e_shnum);
+ hdr->e_machine = TO_NATIVE(hdr->e_machine);
sechdrs = (void *)hdr + hdr->e_shoff;
info->sechdrs = sechdrs;

Mathieu Chouquet-Stringer E-Mail: mchouque@xxxxxxxxx
Never attribute to malice that which can be adequately
explained by stupidity.
-- Hanlon's Razor --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/