Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)

[Christoph Hellwig]

On Thu, Sep 01, 2005 at 04:03:27PM -0400, Jeff Garzik wrote:
> Christoph Hellwig wrote:
> >On Thu, Sep 01, 2005 at 03:48:51PM -0400, Jeff Garzik wrote:
> >
> >>Christoph Hellwig wrote:
> >>
> >>>>+#include <linux/kernel.h>
> >>>>+#include <linux/module.h>
> >>>>+#include <linux/pci.h>
> >>>>+#include <linux/init.h>
> >>>>+#include <linux/blkdev.h>
> >>>>+#include <linux/delay.h>
> >>>>+#include <linux/interrupt.h>
> >>>>+#include <linux/sched.h>
> >>>>+#include <linux/dma-mapping.h>
> >>>>+#include "scsi.h"
> >>>
> >>>
> >>>pleaese don't include "scsi.h" in new drivers.  It will go away soon.
> >>>Use the <scsi/*.h> headers and get rid of usage of obsolete constucts
> >>>in your driver.
> >>
> >>
> >>It stays until the rest of the libata drivers lose the include.
> >>
> >>After ATAPI support is done, I can stop 2.4.x support, and this and 
> >>several other compat-isms will go away.
> >
> >
> >NACK.  Jeff, I accept that you don't want to convert old drivers yet,
> >but this is not acceptable for new drivers.  We don't allow it for any
> >new scsi LLDDs, and that includes libata drivers.
> 
> Sorry, you don't get to NAK that change, since it affects 2.4.x 
> maintenance of this new driver.

Stop that crap now please.  Adding "scsi.h" includes is _not_ allowed
for new drivers, period.  There's no exceptions, not even for
Jeff "I'm part of the calal" Garzik.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/