Re: Change CONFIG_DEVKMEM default value to n

From: Dave Young
Date: Sun Oct 09 2016 - 22:46:19 EST


On 10/07/16 at 05:57am, Greg Kroah-Hartman wrote:
> On Fri, Oct 07, 2016 at 10:04:11AM +0800, Dave Young wrote:
> > Kconfig comment suggests setting it as "n" if in doubt thus move the
> > default value to 'n'.
> >
> > Signed-off-by: Dave Young <dyoung@xxxxxxxxxx>
> > Suggested-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > ---
> > drivers/char/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-x86.orig/drivers/char/Kconfig
> > +++ linux-x86/drivers/char/Kconfig
> > @@ -17,7 +17,7 @@ config DEVMEM
> >
> > config DEVKMEM
> > bool "/dev/kmem virtual device support"
> > - default y
> > + default n
>
> If you remove the "default" line, it defaults to 'n'.

I personally perfer a "default n", but I can update it..

>
> And is it really "safe" to default this to n now?

There is an old article here:
https://lwn.net/Articles/147901/

AFAIK Distributions like Fedora/Debian has disabled it for long time.
If one really need it he can still enable it in his own config file.

>
> thanks,
>
> greg k-h

Thanks
Dave