Re: pre-patch-2.1.107 breaks kmod
Linus Torvalds (torvalds@transmeta.com)
Wed, 24 Jun 1998 16:01:43 -0700 (PDT)
On Thu, 25 Jun 1998, Mikael Pettersson wrote:
>
> The pre-patch-2.1.107 in the testing dir on www.kernel.org
> contains a diff which brackets the core of request_module()
> in kmod.c with a down and an up of a mutex "kmod_sem".
>
> I don't know what problem the mutex is supposed to solve,
> but this change makes kmod non-reentrant and unreliable.
The patch does fix a real problem, though. Some kind of re-entrancy block
is needed to make sure that there aren't two copies of "insmod" trying to
insert the same module at the same time. It is possible that this
re-entrancy block needs to be done by insmod itself, rather than the
kernel.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu