Re: [PATCH net-next 14/15] ice: dpll: fix rclk pin state get and misplaced header macros

From: Ivan Vecera

Date: Tue May 05 2026 - 04:34:49 EST



On 5/4/26 8:38 PM, Keller, Jacob E wrote:


-----Original Message-----
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Sent: Saturday, May 2, 2026 7:10 PM
To: Keller, Jacob E <jacob.e.keller@xxxxxxxxx>
Cc: Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn
<andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
Dumazet <edumazet@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>;
Lobakin, Aleksander <aleksander.lobakin@xxxxxxxxx>; Simon Horman
<horms@xxxxxxxxxx>; Michal Swiatkowski
<michal.swiatkowski@xxxxxxxxxxxxxxx>; Jagielski, Jedrzej
<jedrzej.jagielski@xxxxxxxxx>; Loktionov, Aleksandr
<aleksandr.loktionov@xxxxxxxxx>; Nitka, Grzegorz
<grzegorz.nitka@xxxxxxxxx>; Vecera, Ivan <ivecera@xxxxxxxxxx>;
Kubalewski, Arkadiusz <arkadiusz.kubalewski@xxxxxxxxx>; Nguyen, Anthony L
<anthony.l.nguyen@xxxxxxxxx>; Wegrzyn, Stefan
<stefan.wegrzyn@xxxxxxxxx>; Kwapulinski, Piotr
<piotr.kwapulinski@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH net-next 14/15] ice: dpll: fix rclk pin state get and
misplaced header macros

On Thu, 30 Apr 2026 23:37:25 -0700 Jacob Keller wrote:
Fixes: ad1df4f2d591 ("ice: dpll: Support E825-C SyncE and dynamic pin
discovery")

Why are Fixes going to net-next?

Hm. It was targeted at next in the IWL patchwork. I'm not sure why Ivan chose to do that. I opted to include this in the series because the patches for unmanaged DPLL support have conflicts otherwise due to the placement of the header macros. I didn't consider that "net" material since its relatively minor issue that I think only causes issues if the ice_dpll.h header gets included twice which it doesn't seem to currently.

This was because it fixed a problem recently merged to next and at that
time it didn't make sense to target net branch. Originally it was
submitted on 02/10 !

Thanks,
Ivan