Re: [PATCH v2] ASoC: dt-bindings: sound: renesas,r9a09g047: Fix dma-names and ports schema

From: Rob Herring

Date: Mon Jun 08 2026 - 10:24:37 EST


On Sun, Jun 07, 2026 at 08:50:49PM +0000, John Madieu wrote:
> Hi Rob,
>
> Thanks for your review.
>
> > -----Original Message-----
> > From: Rob Herring (Arm) <robh@xxxxxxxxxx>
> > Sent: Freitag, 5. Juni 2026 23:29
> > To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> > Subject: Re: [PATCH v2] ASoC: dt-bindings: sound: renesas,r9a09g047: Fix
> > dma-names and ports schema
>
> [...]
>
> > >
> > > .../sound/renesas,r9a09g047-sound.yaml | 100 +++++++++---------
> > > 1 file changed, 50 insertions(+), 50 deletions(-)
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-
> > ci/linux/Documentation/devicetree/bindings/sound/renesas,r9a09g047-
> > sound.example.dtb: sound@13c00000 (renesas,r9a09g047-sound):
> > ports:port@0:endpoint:capture:0: [6, 7, 8] is too long
> > from schema $id:
> > http://devicetree.org/schemas/sound/renesas,r9a09g047-sound.yaml
> > /builds/robherring/dt-review-
> > ci/linux/Documentation/devicetree/bindings/sound/renesas,r9a09g047-
> > sound.example.dtb: sound@13c00000 (renesas,r9a09g047-sound):
> > ports:port@0:endpoint:playback:0: [3, 4, 5] is too long
> > from schema $id:
> > http://devicetree.org/schemas/sound/renesas,r9a09g047-sound.yaml
>
> This is the 'items: maxItems: 1' I added on playback/capture per your v7
> Comment [1] on the original audio driver series. These phandles point at
> the ssi-N/src-N/dvc-N sub-nodes, which aren't specifier providers and
> have no #*-cells, so the list isn't split per-entry and the constraint
> trips.
>
> Would you prefer I drop it and keep them as a bare phandle-array, as
> renesas,rsnd.yaml does, or is there a form you'd rather see here?

The problem lies in renesas,rsnd.yaml having no constraints. That
should have the same constraints. However, you really shouldn't be
redefining these properties again here, but refactor whatever is common
into a common schema.

I suppose for fixing the rest of the issues, you can drop 'items:
maxItems: 1' constraint on this patch and address that separately.

Rob