RE: [PATCH v2] ASoC: dt-bindings: sound: renesas,r9a09g047: Fix dma-names and ports schema
From: John Madieu
Date: Mon Jun 08 2026 - 18:03:40 EST
Hi Rob,
Thank you for your feedback.
> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Montag, 8. Juni 2026 16:12
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH v2] ASoC: dt-bindings: sound: renesas,r9a09g047: Fix
> dma-names and ports schema
>
[...]
> >
> > This is the 'items: maxItems: 1' I added on playback/capture per your
> > v7 Comment [1] on the original audio driver series. These phandles
> > point at the ssi-N/src-N/dvc-N sub-nodes, which aren't specifier
> > providers and have no #*-cells, so the list isn't split per-entry and
> > the constraint trips.
> >
> > Would you prefer I drop it and keep them as a bare phandle-array, as
> > renesas,rsnd.yaml does, or is there a form you'd rather see here?
>
> The problem lies in renesas,rsnd.yaml having no constraints. That should
> have the same constraints. However, you really shouldn't be redefining
> these properties again here, but refactor whatever is common into a
> common schema.
Agreed. The dvc/src/ssiu/ssi sub-node layout and the playback/capture
routing are the R-Car rsnd model, so the common parts belong in a shared
schema that both renesas,rsnd.yaml and this binding reference, with the
constraints defined once. It can be prepared as a separate series rather
than folded into this fix, and give rsnd the missing constraints in the
same go.
>
> I suppose for fixing the rest of the issues, you can drop 'items:
> maxItems: 1' constraint on this patch and address that separately.
Will do. I'll drop it on playback/capture (bare phandle-array for now),
which clears the remaining dt_binding_check errors, and respin. The
shared-schema cleanup will follow separately.
Regards,
John