Re: [PATCH rdma-next v3 1/1] RDMA/mana_ib: UC QP support for UAPI

[Jason Gunthorpe]

On Tue, Jun 09, 2026 at 09:40:30AM +0000, Konstantin Taranov wrote:
> > > +int mana_ib_gd_destroy_rnic_qp(struct mana_ib_dev *mdev, struct
> > > +mana_ib_qp *qp)
> > 
> > The function is renamed to _rnic_ to be shared between RC and UC, but  the
> > request/response structs are still named _rc_. Should these be  renamed to
> > _rnic_ as well for consistency? Or does the firmware use  the same destroy
> > command for both QP types?
> 
> Sure, they can be renamed. In the firmware, it is still called RC though, but it can
> be used for all QP types (even UD). So, the name _rc_ is just historical.
> 
> Long, do you want me to rename it?
> 
> Jason, can the patch series accepted, or do I need to send 
> IB_UVERBS_CORE_SUPPORT_ROBUST_UDATA first? 

Yeah, that's what I want to start seeing

And use the proper helpers too:

+	err = ib_copy_to_udata(udata, &resp, min(sizeof(resp), udata->outlen));
+	if (err)
+		goto destroy_qp;

Thats ib_respond_udata() now too

Jason