Re: [PATCH] x86/mm: Consolidate SME comments and use break

From: Dave Hansen

Date: Tue Jun 09 2026 - 10:38:11 EST


On 6/9/26 04:30, Thorsten Blum wrote:
> Combine the two SME comments and use break instead of return to exit the
> switch consistently with the other cases.

Hey Thorsten,

While this arguably makes the code a wee bit more consistent, it does it
at the cost of churn. Churn can introduce bugs. It creates conflicts
with other work and it muddies the git history. I don't think the
risk/return on this kind of thing is worth it.

Also, for pure cleanups, I'd personally appreciate seeing them
concentrated really close after -rc1.