Re: [PATCH] x86/mm: Consolidate SME comments and use break

[Thorsten Blum]

On Tue, Jun 09, 2026 at 07:23:14AM -0700, Dave Hansen wrote:
> On 6/9/26 04:30, Thorsten Blum wrote:
> > Combine the two SME comments and use break instead of return to exit the
> > switch consistently with the other cases.
> 
> Hey Thorsten,
> 
> While this arguably makes the code a wee bit more consistent, it does it
> at the cost of churn. Churn can introduce bugs. It creates conflicts
> with other work and it muddies the git history. I don't think the
> risk/return on this kind of thing is worth it.
> 
> Also, for pure cleanups, I'd personally appreciate seeing them
> concentrated really close after -rc1.

I initially just wanted to fix the broken indentation/formatting here:

	if (cc_platform_has(CC_ATTR_HOST_MEM_ENCRYPT)) {
	/*
	 * SME is mutually exclusive with any of the SEV
	 * features below.
	*/
		pr_cont(" SME\n");
		return;
	}

And then decided to combine both comments and replace return with break
while at it.

Happy to resend it early next cycle unless you prefer that I drop it.

Thanks,
Thorsten