Re: [PATCH 00/20] ASoC: Intel: Use guard() for mutex & spin locks

[Cezary Rojewski]

On 6/11/2026 1:58 PM, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Hi all,
>
> This series converts mutex and spinlock handling in Intel ASoC drivers
> to use guard()/scoped_guard() helpers.
>
> Most patches are straightforward conversions. A few patches include
> small cleanup changes as part of the conversion process; these are
> documented in the individual commit messages. Overall, the series is
> intended to simplify the code and cleanup paths, with no behavioral
> changes to the affected functions.
>
> The series has been compile-tested only.
>
> Best regards,
> Phuc
>
> bui duc phuc (20):
>    ASoC: Intel: catpt: ipc: Use guard() for mutex & spin locks
>    ASoC: Intel: catpt: dsp: Use guard() for mutex locks
>    ASoC: Intel: avs: utils: Use guard() for mutex locks
>    ASoC: Intel: avs: probes: Use guard() for spin locks
>    ASoC: Intel: avs: pcm: Use guard() for mutex & spin locks
>    ASoC: Intel: avs: path: Use guard() for mutex & spin locks
>    ASoC: Intel: avs: loader: Use guard() for mutex locks
>    ASoC: Intel: avs: ipc: Use guard() for mutex & spin locks
>    ASoC: Intel: avs: icl: Use guard() for spin locks
>    ASoC: Intel: avs: debugfs: Use guard() for spin locks
>    ASoC: Intel: avs: debug: Use guard() for spin locks
>    ASoC: Intel: avs: core: Use guard() for mutex & spin locks
>    ASoC: Intel: avs: control: Use guard() for spin locks
>    ASoC: Intel: avs: apl: Use guard() for spin locks
>    ASoC: Intel: atom: sst_stream: Use guard() for mutex locks
>    ASoC: Intel: atom: sst_pvt: Use guard() for mutex & spin locks
>    ASoC: Intel: atom: sst: Use guard() for spin locks
>    ASoC: Intel: atom: sst-atom-controls: Use guard() for mutex locks
>    ASoC: Intel: atom: sst-mfld-platform-pcm: Use guard() for mutex & spin
>      locks
>    ASoC: Intel: atom: sst_ipc: Use guard() for spin locks
Hi Phuc,

Recent changes took care of catpt-driver [1], so the first two patches 
can be dropped.  While I wanted to follow up with the avs-driver, I see 
no reason why I shouldn't let you do that instead.

Now on to the review - there is no need to be as granular as you're 
here.  Two drivers are being updated here: the avs-driver and the 
atom-driver (assuming the catpt-driver patches are already gone). 
Sending a patch per file creates unnecessary traffic, so let's limit the 
set to two changes.

Please use the following scopes for those:
	ASoC: Intel: avs:
	ASoC: Intel: atom:

Last but not least, your name and surname are not capitalized.  That's 
clearly not the case here, in the cover letter.  Please adjust.

[1]: 
https://lore.kernel.org/all/20260603085827.1964796-2-cezary.rojewski@xxxxxxxxx/


Kind regards,
Czarek