Re: [PATCH 00/20] ASoC: Intel: Use guard() for mutex & spin locks

[Bui Duc Phuc]

Hi Czarek,

>
> Recent changes took care of catpt-driver [1], so the first two patches
> can be dropped.  While I wanted to follow up with the avs-driver, I see
> no reason why I shouldn't let you do that instead.
>

Thank you for the feedback and for clarifying the status of the
catpt-driver patches. I'd be happy to take over the avs-driver changes
as well!
By the way, since the catpt changes were already taken care of by someone
else, could you share how you usually check for this so I can avoid duplicate
work in the future?

> Now on to the review - there is no need to be as granular as you're
> here.  Two drivers are being updated here: the avs-driver and the
> atom-driver (assuming the catpt-driver patches are already gone).
> Sending a patch per file creates unnecessary traffic, so let's limit the
> set to two changes.
>
> Please use the following scopes for those:
>         ASoC: Intel: avs:
>         ASoC: Intel: atom:
>

I initially split the series more finely because I was thinking about
bisectability,
but grouping the changes per driver also makes sense.
I'll rework the series accordingly.


> Last but not least, your name and surname are not capitalized.  That's
> clearly not the case here, in the cover letter.  Please adjust.
>

Regarding my name, leaving it lowercase is a small trick to quickly find myself
at the bottom of contribution stats (like LWN:
https://lwn.net/Articles/1075574/).
I capitalize it in emails just for communication.
Unless it's strictly against kernel rules, I'd prefer to keep it this way.

Best regards,
Phuc