Re: [PATCH v2] drm: Guard DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE

[Robert Mader]

Hi,

On 02.07.26 10:34, Maarten Lankhorst wrote:
> Hello,
<snip>
> On 7/2/26 10:16, Robert Mader wrote:
> > diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
> > index e2df4becce62..b2c0234eaf14 100644
> > --- a/drivers/gpu/drm/drm_ioctl.c
> > +++ b/drivers/gpu/drm/drm_ioctl.c
> > @@ -373,13 +373,26 @@ drm_setclientcap(struct drm_device *dev, void *data, struct drm_file *file_priv)
> >   			return -EINVAL;
> >   		file_priv->supports_virtualized_cursor_plane = req->value;
> >   		break;
> > -	case DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE:
> > +	case DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE: {
> > +		struct drm_plane *plane;
> > +		bool has_plane_with_color_pipeline = false;
> > +
> > +		drm_for_each_plane(plane, dev) {
> > +			if (plane->color_pipeline_property) {
> > +				has_plane_with_color_pipeline = true;
> > +				break;
> > +			}
> > +		}
> > +		if (!has_plane_with_color_pipeline)
> > +			return -EOPNOTSUPP;
> > +
> >   		if (!file_priv->atomic)
> >   			return -EINVAL;
> >   		if (req->value > 1)
> >   			return -EINVAL;
> >   		file_priv->plane_color_pipeline = req->value;
> >   		break;
> > +	}
> Perhaps put the most specific check (is there a plane with color pipeline?)
> last, and return -EINVAL, as that is the default before
> DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE was added.
>
> Kind regards,
> ~Maarten Lankhorst
Thanks, will do so in v3. Will wait a bit more for further feedback and 
send it out tomorrow.

--
Robert Mader
Consultant Software Developer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718