Re: [PATCH 2/2] hwmon: (pmbus) Add driver for Analog Devices MAX20912 and MAX20916
From: Guenter Roeck
Date: Thu Jul 09 2026 - 11:51:18 EST
On Thu, Jul 09, 2026 at 03:23:55PM +0800, Fred Chen wrote:
>
> Based on the MAX20912/16 specs on my hand, these chips do not support
> PMBUS_PHASE (0x04). Furthermore, the spec only indicates support for VID mode
> and does not provide m/b/r. Therefore, some of the features you mentioned might
> be specific to the MAX20826 series.
FWIW, phase support can be implemented in the chip driver. Other chips
such as MAX16601 don't support the standard phase command either.
>
> Regarding enabling VOUT via GPIO, our platform handles this via the CPLD as
> part of the hardware power sequencing. Managing this pin through the driver is
> not a requirement for our system.
That would normally be the case, but if the chip mandates the use of the EN pin
the driver should support (but not mandate) it. I would not expect you to implement
it, though, if you can not test it. This functionality is critical enough that
it should be implemented and tested by someone with access to hardware using it.
Thanks,
Guenter