Re: [RFC PATCH 0/6] selftests/vfio: Add sPAPR TCE v2 coverage

From: David Matlack

Date: Thu Jul 09 2026 - 11:51:51 EST


On Thu, Jul 9, 2026 at 1:49 AM Narayana Murty N <nnmlinux@xxxxxxxxxxxxx> wrote:

> >> Feedback is requested from the VFIO and PowerPC communities on:
> >> 1. whether the sPAPR TCE v2 helpers should remain in the common VFIO
> >> selftest library or move into a sPAPR-specific test helper?
> > Responded in the patch. Let's move to their own file.
> Will do. v2 will have:
>
> lib/iommu_spapr.c — all sPAPR logic, compiled only on powerpc
> lib/iommu_spapr_stub.c — empty stubs returning -EOPNOTSUPP,
> compiled on all other architectures
> lib/include/libvfio/iommu_spapr.h — declarations

Just one small thing here: You can put all the stubs in iommu_spapr.h
as static inlines, then you don't need the extra C file. e.g.

#ifdef __powerpc__

... prototypes ...

#else

... static inline stubs ...

#endif