Re: 2.6.15-rc2 pci_ids.h cleanup is a pain

[Grant Coady]

Hi Andrew, Greg,

On Tue, 22 Nov 2005 16:25:58 -0800, Andrew Morton <akpm@xxxxxxxx> wrote:

>Greg KH <greg@xxxxxxxxx> wrote:
>>
>> On Mon, Nov 21, 2005 at 02:27:23PM -0800, David Fox wrote:
>> > I'm sure I'm not the only person that applies patches to the kernel that 
>> > use some of the 500 plus PCI IDS eliminated from pci_ids.h by rc2.  I 
>> > would like to see the PCI ids that were removed simply because the don't 
>> > occur in the main kernel source restored.  Is there a rationale for 
>> > removing them that I'm not aware of?
>> 
>> They were not being used.  Why would you want them in there?
>
>Because they contained useful information which had been accumulated by
>many people over a long period of time.
>
>Throwing that information away seemed rather pointless, especially as the
>cost of retaining it was so low.

There's an out-of-tree reference, the pci.ids website, that carries 
this information, do we need the reference info in the kernel as well?  

So far two people raised an objection, the other wants to maintain 
an out-of-tree driver, D. Fox didn't say why he needs the symbols.

There's some other cleanups to be done yet, as >100 files define 
own PCI_* symbols instead of referencing the header...


Would you prefer to revert the patches or rather me put the removed 
symbols back again via a new patch series?

Cheers,
Grant.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/