Re: [Regression] 2.6.24-git3: Major annoyance duringsuspend/hibernation on x86-64 (bisected)

From: Ingo Molnar
Date: Fri Feb 01 2008 - 18:25:13 EST



* Rafael J. Wysocki <rjw@xxxxxxx> wrote:

> On Friday, 1 of February 2008, Rafael J. Wysocki wrote:
> > On Friday, 1 of February 2008, Ingo Molnar wrote:
> > >
> > > * Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:
> > >
> > > > The below fixes it for me..
> > > >
> > > > ---
> > > > - restore the old wakeup mechanism
> > > > - fix break usage in do_each_thread() { } while_eac_thread().
> > > > - fix the hotplug switch stmt, a fall-through case was broken.
> > >
> > > thanks Peter, i've picked your fix up. I hope this solves the problem
> > > for Rafael too.
> >
> > No, it doesn't, unfortunately. Actually, it breaks things even more, as
> > suspend now hangs (probably deadlocks) while disabling the nonboot CPU.
>
> For some obscure reason, I'm no longer able to reproduce the problem
> with the Peter's patch and I think it's correct. You can add
>
> Tested-by: Rafael J. Wysocki <rjw@xxxxxxx>
>
> to it.

Great! I sent the fix to Linus with your Tested-by line. Thanks Rafael
for all the testing!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/