Re: [PATCH] intel_ips: quieten "power or thermal limit exceeded"messages

[Alan Cox]

On Thu, 26 Aug 2010 20:29:01 -0300
Cesar Eduardo Barros <cesarb@xxxxxxxxxx> wrote:

> On my Dell Inspiron N4010, one of these messages is printed every five
> seconds. Change both to dev_dbg to quieten them even more.

It's not the kind of thing you want to quieten since in most cases it is
stuff you want to know about.

> 
> Signed-off-by: Cesar Eduardo Barros <cesarb@xxxxxxxxxx>
> ---
>  drivers/platform/x86/intel_ips.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> index 9024480..7833adc 100644
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -607,7 +607,7 @@ static bool mcp_exceeded(struct ips_driver *ips)
>  	spin_unlock_irqrestore(&ips->turbo_status_lock, flags);
>  
>  	if (ret)
> -		dev_info(&ips->dev->dev,
> +		dev_dbg(&ips->dev->dev,
>  			 "MCP power or thermal limit exceeded\n");

Probably better to ratelimit it. Being told it occurs is important, being
told every five seconds is indeed excessive.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/