Re: [PATCH 2/2] kernel/rcu/rcutorture.c: use macro to define module parameter

[Paul E. McKenney]

On Wed, Apr 16, 2014 at 07:10:41PM -0400, Pranith Kumar wrote:
> On Wed, Apr 16, 2014 at 5:14 PM, Paul E. McKenney
> <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > This fails for me.  The problem is that the defined macro makes everything
> > static, and rcutorture_runnable is used in kernel/sysctl.c.  :-/
> >
> > In theory, it would be possible to make torture_param() take "static"
> > as a parameter, but this adds more characters than it removes.
> >
> 
> Oh, I just tried building it as a module and it worked. In the future
> I will run this both as inbuilt and as a module before sending any
> patches.
> 
> Sorry for the noise!

This is not noise!  I do intend to use it as a module in the future, so
it is helpful that you found and fixed the other bugs.  I really cannot
complain about one bad patch out of several useful fixes!  So please
do keep trying things and looking at things in RCU.  ;-)

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/