Re: [PATCH v2 5/5] regulator: tps65090: Make FETs more reliable by adding retries

[Simon Glass]

Hi Doug,

On 16 April 2014 15:25, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> Simon,
>
> On Wed, Apr 16, 2014 at 1:50 PM, Simon Glass <sjg@xxxxxxxxxxxx> wrote:
>>> +#define MAX_CTRL_READ_TRIES    5
>>> +#define MAX_FET_ENABLE_TRIES   1000
>>
>> Gosh that is a lot of tries - should we maybe give up sooner?
>
> That's actually a squash of a recent patch.  See
> <https://chromium-review.googlesource.com/189239>.  I've specifically
> seen at least one case on my device where it needed 888 retries at
> bootup!
>
> ...on my really old Chromebook, it seems to get into a bad state if it
> sits on my desk for a long time.  After I use it a bit it rarely needs
> more than 10 retries.

Try to be kinder to your hardware?

Anyway, fair enough, if you've seen 888 then we need to deal with that case.

Regards,
Simon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/