Re: [PATCH v4] control groups: documentation improvements

From: Tejun Heo
Date: Thu Apr 17 2014 - 09:56:00 EST


Hello,

On Thu, Apr 17, 2014 at 02:45:40PM +0100, Glyn Normington wrote:
> >>+The sets of subsystems participating in distinct hierarchies are either
> >>+identical or disjoint. If the sets are identical, the virtual filesystems
> >>+associated with the hierarchies have identical content and a change in
> >>+one is automatically reflected in all the others.
> >
> >I can't say I'm a big fan of these definitions in mathematical terms.
> >They're so precise and useless at the same time.
>
> We would like to be both precise and readable. Please point out the
> "useless" bits and we'll try to make them better.

I think it becomes useless when mathematical precision is pursued
beyond the necessary point, forcing people to parse and analyze the
description to reach a concept she already has full understanding of.
Just using those pre-established concepts is far more efficient use of
brain power than trying to craft the precise mathematical definition
from vacuum and, [un]surprisingly, leads to lower rate of
miscommunication.

It's kinda useless to go through all the precise terms to re-define
hierarchical grouping of tasks, which is both accurate and intuitive
enough. Adding extra descriptions to clarify ambiguities and just to
reinforce the concept would be fine but trying to build the concept
from the ground is silly at best. Starting with something intuitive
and refining it is a far better approach.

> A given hierarchy may be associated with more than one virtual
> filesystem, in which case each of the virtual filesystems has
> identical contents to the others.

The above is inaccurate because there really is just one filesystem
(represented by a single super block). There are multiple mount
points of the same file system, but still just single file system.
ie. mounting /dev/sdb2 in multiple places doens't really create
multiple file systems.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/