Re: [PATCH 0/2] memcg: mm_update_next_owner() should skip kthreads

From: Michal Hocko
Date: Fri Apr 18 2014 - 14:24:59 EST


On Fri 18-04-14 19:26:31, Oleg Nesterov wrote:
> On 04/18, Oleg Nesterov wrote:
> >
> > Hmm. I seem to see a bug in this function, it can be fulled by use_mm,
> > but I am not sure this can explain the problem. I'll send a patch.
>
> Untested, please review. But it really looks "obviously wrong", and note
> that unuse_mm() doesn't do mm_update_next_owner(). (just in case, do not
> confuse it with unuse_mm() in mm/swapfile.c).

Both patches seem to be correct but I am missinng why they are marked as
memcg: when they are touching generic mm_update_next_owner path.

Anyway, feel free to add
Reviewed-by: Michal Hocko <mhocko@xxxxxxx>
--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/