Re: [PATCHv3 07/14] HSI: Add common DT binding for HSI client devices

[Pavel Machek]

On Sat 2014-03-29 01:31:43, Sebastian Reichel wrote:
> Implement and document generic DT bindings for HSI clients.
> 
> Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx>

Reviewed-by: Pavel Machek <pavel@xxxxxx>

> diff --git a/drivers/hsi/hsi.c b/drivers/hsi/hsi.c
> index 07e1639..5973906 100644
> --- a/drivers/hsi/hsi.c
> +++ b/drivers/hsi/hsi.c
> @@ -26,8 +26,14 @@
>  #include <linux/slab.h>
>  #include <linux/string.h>
>  #include <linux/notifier.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
>  #include "hsi_core.h"


> +	err = hsi_of_property_parse_mode(client, "hsi-mode", &mode);
> +	if (err) {
> +		err = hsi_of_property_parse_mode(client, "hsi-rx-mode",
> +						 &cl->rx_cfg.mode);
> +		if (err)
> +			goto err;
> +
> +		err = hsi_of_property_parse_mode(client, "hsi-tx-mode",
> +						 &cl->tx_cfg.mode);
> +		if (err)
> +			goto err;

Will this need some #ifdef CONFIG_OF? 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/