Re: [PATCH v2 1/2] mfd: sec-core: Remove duplicated device type from sec_pmic_dev

From: Lee Jones
Date: Tue Apr 22 2014 - 05:36:27 EST


> The device type was stored in sec_pmic_dev state container twice:
> - unsigned long type (initialized from of_device_id or i2c_device_id)
> - int device_type (initialized as above or from board files when there
> is no DTS)
>
> The 'type' field was never used outside of probe so it can be safely
> removed.
>
> Change also the device_type in sec_pmic_dev and sec_platform_data to
> unsigned long to avoid any casts.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>
> ---
>
> Changes since v1:
> - Change device_type field of sec_platform_data from int to unsigned long.
> - Update commit msg.
> ---
> drivers/mfd/sec-core.c | 5 +++--
> drivers/mfd/sec-irq.c | 2 +-
> include/linux/mfd/samsung/core.h | 3 +--
> 3 files changed, 5 insertions(+), 5 deletions(-)

Patch looks good now. Applied, thanks.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/