Re: [PATCH] perf/x86/intel: Use rdmsrl_safe when initializing RAPL PMU.

[Stephane Eranian]

On Wed, Apr 23, 2014 at 5:16 PM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> On Wed, Apr 23, 2014 at 05:14:33PM +0200, Stephane Eranian wrote:
>> Wouldn't rdmsrl_safe() return 0 on success?
>
> Yes.
>
then the if() test is wrong:
if (!rdmsrl_safe())
   return -1;

Should be:
if (rdmsrl_safe())
  return -1;

Or am I missing something?


> --
> Regards/Gruss,
>     Boris.
>
> Sent from a fat crate under my desk. Formatting is fine.
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/