Re: [PATCH RFC] blkcg: prepare blkcg knobs for default hierarchy

[Vivek Goyal]

On Wed, Apr 23, 2014 at 01:01:41PM -0400, Tejun Heo wrote:
> On Tue, Apr 15, 2014 at 10:18:26AM -0400, Vivek Goyal wrote:
> > Ok, that's fine. Let us just document the knobs well so that people can
> > find which knob is giving what information and make cfq names better at
> > the expense of inconsistency of names with throttling layer.
> 
> I've been thinking about it more.  Why do we even have separate stats
> for common things like bytes transferred?  It doesn't serve any
> purpose to do double accounting and reporting on everything, does it?
> Shouldn't we just have single set of common stats for things like
> requests / bytes serviced?

I think we should just require two. One for measuring rate in terms
of IOPS and other for measuring rate in terms of [kMG]B/sec.

So exporting both sector and bytes seems redundant. May be exporting
bytes and dropping sector interface will do. Is size of sector exported
somewhere so that user space can easily convert bytes to sector if needed.

Number of bio/requests also will need to be exported so that one can come
up with IOPS.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/