Re: [PATCH] perf/x86: fix RAPL rdmsrl_safe() usage

From: Venkatesh Srinivas
Date: Wed Apr 23 2014 - 15:27:37 EST


On Wed, Apr 23, 2014 at 12:00 PM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> On Wed, Apr 23, 2014 at 07:04:19PM +0200, Stephane Eranian wrote:
>>
>> This patch fixes a bug introduced by commit 24223657.
>
> Maybe add
>
> Fixes: <commit-id>
>
> tag?
>
>> The rdmsrl_safe() function returns 0 on success.
>> The current code was failing to detect the RAPL PMU
>> on real hardware (missing /sys/devices/power) because
>> the return value of rdmsrl_safe() was misinterpreted.
>>
>> Signed-off-by: Stephane Eranian <eranian@xxxxxxxxxx>
>
> Acked-by: Borislav Petkov <bp@xxxxxxx>

Brown-Paper-Bag-Worn-By: Venkatesh Srinivas <venkateshs@xxxxxxxxxx>

-- vs;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/