Re: [PATCH] perf/x86: fix RAPL rdmsrl_safe() usage

From: Andi Kleen
Date: Wed Apr 23 2014 - 16:00:34 EST


> > Acked-by: Borislav Petkov <bp@xxxxxxx>
>
> Brown-Paper-Bag-Worn-By: Venkatesh Srinivas <venkateshs@xxxxxxxxxx>

Again the bug is really in KVM. We wouldn't need all this crap
if KVM didn't throw the bogus #GPs. I'm sure you missed plenty
of MSR accesses elsewhere, and it's a ticking time bomb.

If the VM lies to the kernel with the family-model you need to at
least limit the consequences. KVM is spectacularly failing
to do that by throwing bogus #GPs.

The brown paper bad needs to be employed on the KVM code
(or better the bug be fixed there, by defaulting to not #GP
on unknown MSRs)

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/