Re: [PATCH V3 1/3] x86/PCI: Fix PCI root numa_node info on AMD family15h

From: Robert Richter
Date: Thu May 08 2014 - 05:02:00 EST


On 08.05.14 10:59:05, Robert Richter wrote:
> On 07.05.14 13:58:45, suravee.suthikulpanit@xxxxxxx wrote:
> > @@ -113,10 +122,17 @@ static int __init early_fill_mp_bus_info(void)
> > info = alloc_pci_root_info(min_bus, max_bus, node, link);
> > }
> >
> > + /*
> > + * The following code is only supported until Fam11h.
> > + * Newer processors will depend on ACPI MCFG table instead.
> > + */
> > + if (boot_cpu_data.x86 > 0x11)
> > + return 0;
> > +
> > /* get the default node and link for left over res */
>
> As this is the only substantial change of your patch, I would better
> drop ther rest or at least split it in two patches. Should this change
> also be for stable?

Of course adding the hostbridge must be also part of the patch, didn't
note this due to the other noise. See why the split would be good?

>
> -Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/