Re: [PATCH] title: no lookup_page for if statement

[Nick Krause]

On Mon, Jul 14, 2014 at 2:59 PM, Paul Bolle <pebolle@xxxxxxxxxx> wrote:
> On Mon, 2014-07-14 at 14:49 -0400, Nicholas Krause wrote:
>> This patch removes the if define statement for page_lookup in order
>> to remove a fix me of this not being defined as of yet.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
>> ---
>>  0001-title-no-lookup_page-for-if-statement.patch | 37 ++++++++++++++++++++++++
>>  1 file changed, 37 insertions(+)
>>  create mode 100644 0001-title-no-lookup_page-for-if-statement.patch
>>
>> diff --git a/0001-title-no-lookup_page-for-if-statement.patch b/0001-title-no-lookup_page-for-if-statement.patch
>> new file mode 100644
>> index 0000000..f11c12e
>> --- /dev/null
>> +++ b/0001-title-no-lookup_page-for-if-statement.patch
>> @@ -0,0 +1,37 @@
>> +From 23c4afac6742d5df1d083ab6335a0a69f38c76b0 Mon Sep 17 00:00:00 2001
>> +From: Nicholas Krause <xerofoify@xxxxxxxxx>
>> +Date: Mon, 14 Jul 2014 14:39:02 -0400
>> +Subject: [PATCH] title: no lookup_page for if statement
>> +
>> +This patch removes the if define statement for page_lookup in order
>> +to remove a fix me of this not being defined as of yet.
>> +
>> +Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
>> +---
>> + arch/tile/mm/fault.c | 3 ---
>> + 1 file changed, 3 deletions(-)
>> +
>> +diff --git a/arch/tile/mm/fault.c b/arch/tile/mm/fault.c
>> +index 6c05712..2297bf7 100644
>> +--- a/arch/tile/mm/fault.c
>> ++++ b/arch/tile/mm/fault.c
>> +@@ -513,8 +513,6 @@ no_context:
>> +
>> +     bust_spinlocks(1);
>> +
>> +-    /* FIXME: no lookup_address() yet */
>> +-#ifdef SUPPORT_LOOKUP_ADDRESS
>
> Nicholas, stop! Just stop.
>
>> +     if (fault_num == INT_ITLB_MISS) {
>> +             pte_t *pte = lookup_address(address);
>> +
>> +@@ -523,7 +521,6 @@ no_context:
>> +                            " non-executable page - exploit attempt?"
>> +                            " (uid: %d)\n", current->uid);
>> +     }
>> +-#endif
>> +     if (address < PAGE_SIZE)
>> +             pr_alert("Unable to handle kernel NULL pointer dereference\n");
>> +     else
>> +--
>> +1.9.1
>> +
>
> For those not yet familiar with this train wreck, please do
>     git grep SUPPORT_LOOKUP_ADDRESS
>
>
> Paul Bolle
>

Very well , I will not work on this any longer as I seem to be just
screwing it up.
Cheers Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/