Re: [PATCH] crypto: testmgr.c: white space fix-ups on test_aead

From: Horia GeantÄ
Date: Fri Aug 08 2014 - 05:23:18 EST


On 7/28/2014 1:11 PM, Cristian Stoica wrote:
> This patch inverts two if conditions and allows removal of one
> tab-stop in their code-blocks. Only white-space clean-up follows.
>
> Signed-off-by: Cristian Stoica <cristian.stoica@xxxxxxxxxxxxx>
> ---
> crypto/testmgr.c | 498 +++++++++++++++++++++++++++----------------------------
> 1 file changed, 242 insertions(+), 256 deletions(-)

This increases readability and reduces number of lines, not to mention
cyclomatic complexity.

While here, could you do this also for other places, like __test_hash?

Thanks,
Horia


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/