Re: [PATCH] resource: Fix the case of null pointer access

From: Vivek Goyal
Date: Tue Aug 12 2014 - 11:04:52 EST


On Tue, Aug 12, 2014 at 04:49:35PM +0200, Richard Weinberger wrote:
> Am 12.08.2014 16:46, schrieb Vivek Goyal:
> > Richard and Daniel reported that UML is broken due to changes to resource
> > traversal functions. Problem is that iomem_resource.child can be null
> > and new code does not consider that possibility. Old code used a for loop
> > and that loop will not even execute if p was null.
> >
> > Revert back to for() loop logic and bail out if p is null.
> >
> > I also moved sibling_only check out of resource_lock. There is no
> > reason to keep it inside the lock.
> >
> > Following is backtrace of the UML crash.
>
> Shall I pickup this patch and route it via my uml tree to Linus?

I am fine with that.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/