Re: [tip:locking/arch] locking,arch,avr32: Fold atomic_ops
From: Peter Zijlstra
Date: Thu Aug 14 2014 - 15:30:32 EST
On Thu, Aug 14, 2014 at 09:27:20PM +0200, Hans-Christian Egtvedt wrote:
> Around Thu 14 Aug 2014 10:19:44 -0700 or thereabout, tip-bot for Peter Zijlstra wrote:
> > Commit-ID: d325209b6000dcd13404ee946d2292e15a56718c
> > Gitweb: http://git.kernel.org/tip/d325209b6000dcd13404ee946d2292e15a56718c
> > Author: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > AuthorDate: Wed, 9 Apr 2014 21:51:29 +0200
> > Committer: Ingo Molnar <mingo@xxxxxxxxxx>
> > CommitDate: Thu, 14 Aug 2014 12:48:05 +0200
> >
> > locking,arch,avr32: Fold atomic_ops
> >
> > Many of the atomic op implementations are the same except for one
> > instruction; fold the lot into a few CPP macros and reduce LoC.
> >
> > This also prepares for easy addition of new ops.
> >
> > Requires the asm_op because of eor.
> >
> > AVR32 is a bit special in that its ADD/SUB instructions are not
> > symmetric. Its SUB instruction allows for an 21bit immediate.
>
> Fantastic, looks great.
>
> Do you have any plans for merge route? I'll happily do it through the avr32
> tree, but if it is part of another series, it makes most sense to do it
> there.
I was thinking to keep the lot together in tip/locking/arch.
Once that lands, I'll need to clean up and send pass 3, which
_hopefully_ will be the last, although I had vague plans for a 4th as
well.
Attachment:
pgpAAiYQkA1h1.pgp
Description: PGP signature